-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose "reset" color value in themes #8083
Conversation
Since I can't put this in the title, this fixes #8075 to be clear. |
@@ -70,6 +70,7 @@ over it and is merged into the default palette. | |||
|
|||
| Color Name | | |||
| --- | | |||
| `reset` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps the documentation could use a more extensive update.
The default palette uses the terminal's default 16 colors
That does no longer correspond to the list of identiefiers below it. I might send a PR at some point making some clarifications to this documentation chapter in general.
I had a look at how the As you see, it's translated to code 39 and 49 which correspond to the default fg and bg colors. In this light, shouldn't we rather expose this as "default" instead of "reset"? The phrase "reset" could then be reserved for the actual reset code ( |
Seems like this was a pretty trivial fix, but please let me know if you spot anything obviously wrong here.
I tested it and it seemed like you could pretty easily modify
reset
to whatever you want and have it show up in your theme.