Enhance :toggle to support cycling numbers #7877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alevinval
commented
Aug 8, 2023
helix-term/src/commands/typed.rs
Outdated
| anyhow::bail!("Configuration {key} does not support toggle yet") | ||
| } | ||
| }; | ||
|
|
||
| let status = format!("'{key}' is now set to {value}"); | ||
| let config = serde_json::from_value(config) | ||
| .map_err(|_| anyhow::anyhow!("Could not parse field: `{:?}`", &args))?; | ||
| .map_err(|err| anyhow::anyhow!("Error parsing `{:?}`, reason: {:?}", &args, err))?; |
There was a problem hiding this comment.
I felt like updating the error message so its clear to the user why its failing, see how it will look like in case someone puts decimals or negative integers:
alevinval
force-pushed
the
issue-4411-support-toggle-numbers
branch
from
c5943c4
to
7ffa1dd
Compare
pascalkuthe
approved these changes
Aug 8, 2023
the-mikedavis
approved these changes
Aug 9, 2023
the-mikedavis
changed the title
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update toggle implementation to accept toggling numbers. Thanks to #4411 (comment) where it became clear that adding support for it is quite trivial.