build(deps): bump lsp-types from 0.94.0 to 0.94.1

[dependabot]

Bumps lsp-types from 0.94.0 to 0.94.1.

Changelog

Sourced from lsp-types's changelog.

v0.94.1 (2023-08-07)

Commits

• 2b20769 chore: Release lsp-types version 0.94.1
• 78f4ccb Update changelog
• af4f8e0 Merge pull request #258 from ebkalderon/add-missing-diagnostic-requests
• c828d38 Merge pull request #256 from attila-lin/dev/doc
• 5f31df6 Merge pull request #263 from SKalt/patch-1
• 6d41843 Merge pull request #262 from oxalica/fix/macro-workspace-symbol-resolve
• 96e133e docs: fix typo
• f1e5e99 Fix missing workspaceSymbol/resolve for lsp_request!
• aed3b08 Add support for workspace/diagnostic{,/refresh}
• 15cd92c Add support for textDocument/diagnostic request
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[the-mikedavis]

Connects #7757 as this release contains the textDocument/diagnostic type

[danillos]

@the-mikedavis After merge it rubocop LSP stopped to work.

It shows this error:

2023-08-26T11:07:16.905 helix_lsp [ERROR] failed to initialize language server: failed to parse: data did not match any variant of untagged enum DiagnosticServerCapabilities

I'm using it as:

[language-server.rubocop]
command = "rubocop"
args = ["--lsp", "--stderr", "--fail-level", "fatal"]
timeout = 3

[the-mikedavis]

What does the log say when running in verbose mode? (hx -v)

[danillos]

What does the log say when running in verbose mode? (hx -v)

2023-08-26T12:00:34.861 helix_lsp::transport [INFO] rubocop -> {"jsonrpc":"2.0","method":"initialize","params":{"capabilities":{"general":{"positionEncodings":["utf-8","utf-32","utf-16"]},"textDocument":{"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":["","quickfix","refactor","refactor.extract","refactor.inline","refactor.rewrite","source","source.organizeImports"]}},"dataSupport":true,"disabledSupport":true,"isPreferredSupport":true,"resolveSupport":{"properties":["edit","command"]}},"completion":{"completionItem":{"deprecatedSupport":true,"insertReplaceSupport":true,"resolveSupport":{"properties":["documentation","detail","additionalTextEdits"]},"snippetSupport":true,"tagSupport":{"valueSet":[1]}},"completionItemKind":{}},"hover":{"contentFormat":["markdown"]},"inlayHint":{"dynamicRegistration":false},"publishDiagnostics":{"versionSupport":true},"rename":{"dynamicRegistration":false,"honorsChangeAnnotations":false,"prepareSupport":true},"signatureHelp":{"signatureInformation":{"activeParameterSupport":true,"documentationFormat":["markdown"],"parameterInformation":{"labelOffsetSupport":true}}}},"window":{"workDoneProgress":true},"workspace":{"applyEdit":true,"configuration":true,"didChangeConfiguration":{"dynamicRegistration":false},"didChangeWatchedFiles":{"dynamicRegistration":true,"relativePatternSupport":false},"executeCommand":{"dynamicRegistration":false},"inlayHint":{"refreshSupport":false},"symbol":{"dynamicRegistration":false},"workspaceEdit":{"documentChanges":true,"failureHandling":"abort","normalizesLineEndings":false,"resourceOperations":["create","rename","delete"]},"workspaceFolders":true}},"clientInfo":{"name":"helix","version":"23.05 (15e07d4d)"},"processId":13081,"rootPath":"/Users/danillos/Work/tidy/projects/workflow-service","rootUri":"file:///Users/danillos/Work/tidy/projects/workflow-service","workspaceFolders":[{"name":"workflow-service","uri":"file:///Users/danillos/Work/tidy/projects/workflow-service"}]},"id":0}
2023-08-26T12:00:35.658 helix_lsp::transport [INFO] rubocop <- {"id":0,"result":{"capabilities":{"textDocumentSync":{"openClose":true,"change":1},"documentFormattingProvider":true,"diagnosticProvider":true}},"jsonrpc":"2.0"}
2023-08-26T12:00:35.658 helix_lsp::transport [INFO] rubocop <- {"capabilities":{"diagnosticProvider":true,"documentFormattingProvider":true,"textDocumentSync":{"change":1,"openClose":true}}}
2023-08-26T12:00:35.658 helix_lsp [ERROR] failed to initialize language server: failed to parse: data did not match any variant of untagged enum DiagnosticServerCapabilities

[the-mikedavis]

It looks like rubocop is breaking the spec a bit here: https://github.com/microsoft/language-server-protocol/blob/df3e8a217c04239ce3e3e4240b7002d1ce3abf98/_specifications/lsp/3.17/general/initialize.md?plain=1#L861-L866

The spec says that diagnosticProvider should either be omitted, DiagnosticOptions or DiagnosticRegistrationOptions:

        /**
         * The server has support for pull model diagnostics.
         *
         * @since 3.17.0
         */
        diagnosticProvider?: DiagnosticOptions | DiagnosticRegistrationOptions;

but instead it's set to true. We didn't catch this before upgrading this dependency since lsp_types 0.94.1 added the pull diagnostics types including this diagnosticProvider field (see here), so we ignored the field.

[danillos]

Thank you @the-mikedavis, I filled a bug report there and they already created a fix.