Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(health): show info about multiple lsp/dap binaries #7833

Closed
wants to merge 3 commits into from

Conversation

woojiq
Copy link
Contributor

@woojiq woojiq commented Aug 4, 2023

This PR introduces two changes:

  1. Add support for multiple health arguments. E.g, hx --health rust ruby (05d1f94)
  2. Show information about all lsp/dap binaries when hx --health or hx --health <lang> (5c4b873)

It doesn't close any existing issues afaik, but removes some TODOs introduced in #2507.
If you are not happy with the first change, I can rebase the branch to contain only the second.

asciinema

@gabydd
Copy link
Member

gabydd commented Aug 4, 2023

see also #7315

@woojiq
Copy link
Contributor Author

woojiq commented Aug 4, 2023

Ty, I haven't seen this PR, only #5692.

Will it be possible to specify the languages to display as such: hx --health lang1 lang2...langn?

Well I don't think it would be difficult to implement, but I think it should be done in a different PR.

So yeah, I can rebase this PR to only include the first change, while the second is already implemented in #7315.

@woojiq
Copy link
Contributor Author

woojiq commented Aug 4, 2023

Well, that issue also has a pr. No problem, gonna watch netflix 😿

@woojiq woojiq closed this Aug 4, 2023
@woojiq woojiq deleted the improve-health branch August 7, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants