enhanced surround_replace to provide visual feedback
#7588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alevinval
force-pushed
the
highlight-surround-replace
branch
from
a4dbf22
to
0d022d2
Compare
alevinval
changed the title
alevinval
force-pushed
the
highlight-surround-replace
branch
from
0d022d2
to
3dc4ad9
Compare
When the target character is pressed, the selection is temporarily updated to display the affected positions. It restores the original selection after the operation is cancelled or completed.
alevinval
force-pushed
the
highlight-surround-replace
branch
from
3dc4ad9
to
f26677d
Compare
archseer
reviewed
Jul 10, 2023
archseer
reviewed
Jul 10, 2023
alevinval
force-pushed
the
highlight-surround-replace
branch
from
a936383
to
6705e0f
Compare
alevinval
force-pushed
the
highlight-surround-replace
branch
from
6705e0f
to
a558743
Compare
alevinval
changed the title
surround_replace to provide visual feedback
archseer
reviewed
Jul 11, 2023
alevinval
force-pushed
the
highlight-surround-replace
branch
from
ca77e5b
to
78fa40e
Compare
alevinval
force-pushed
the
highlight-surround-replace
branch
from
78fa40e
to
6127ff3
Compare
archseer
reviewed
Jul 11, 2023
archseer
reviewed
Jul 12, 2023
helix-term/src/commands.rs
Outdated
| @@ -5115,11 +5115,15 @@ fn surround_replace(cx: &mut Context) { | |||
| } | |||
| }; | |||
|
|
|||
| let selection = selection.clone(); | |||
| let ranges: SmallVec<_> = change_pos.iter().map(|&pos| Range::point(pos)).collect(); | |||
| doc.set_selection(view.id, Selection::new(ranges, 0)); | |||
There was a problem hiding this comment.
Okay, one last thing: you need to compute the correct primary_idx here or the view will be moved if you have a lot of selections: if you selected all the lines in a very big file and were viewing somewhere further down, an index of 0 would move the view all the way to the top
Something like
let primary = selection.primary();
let (i, _) = ranges.iter().enumerate().find(|_i, range| range.overlaps(primary))...
Selection::new(ranges, i)There was a problem hiding this comment.
Good point. I've pushed this change and so far so good during smoke testing, but I wonder if there's a better way.
There was a problem hiding this comment.
There is a better way. There should be twice as many matches (surrounding positions) as original selections, so the primary index of this selection is twice the original selection primary index.
pascalkuthe
approved these changes
Jul 13, 2023
pascalkuthe
added
E-easy
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the target character is pressed, the selection is temporarily updated to display the affected positions. It restores the original selection after the operation is cancelled or completed.