use redraw handle for debouncing LSP messages #7538
Conversation
pascalkuthe
added
C-bug
| @@ -609,12 +603,7 @@ impl Application { | |||
| EditorEvent::LanguageServerMessage((id, call)) => { | |||
| self.handle_language_server_message(call, id).await; | |||
| // limit render calls for fast language server messages | |||
| let last = self.editor.language_servers.incoming.is_empty(); | |||
There was a problem hiding this comment.
For context: the is_empty here checks that the set of streams is empty rather than that there is no pending message ready to be handled. Detecting that case is a little involved and not very effective for debouncing (see #7373 (comment))
| @@ -1703,7 +1703,7 @@ impl Editor { | |||
| _ = self.redraw_handle.0.notified() => { | |||
| if !self.needs_redraw{ | |||
| self.needs_redraw = true; | |||
| let timeout = Instant::now() + Duration::from_millis(96); | |||
| let timeout = Instant::now() + Duration::from_millis(33); | |||
There was a problem hiding this comment.
The only disadvantage of this approach was that the rendering now has a longer render timeout (96ms instead of 16ms) which felt a bit slow. I changed it to 33ms to emulate 30FPS. It doesn't matter too much for diff gutters what that value is since diff gutters only use this as a fallback mechanism but I would prefer to not lower this too much more to avoid adding too many renders.
We were rendering with approximately 60fps in the past (the debouncer wasn't exact but we were using 16 ms to debounce). The redraw handle used to have a longer timeout since its only used as a fallback for the diff gutters (basically if we get here its already slow) but the exact value doesn't matter too much. I lowered it so we at least keep rending with 30 FPS. I didn't want to go quite as low as 16 here, if we really care we could allow different users of the redraw handle to specify different timeouts. That seemed overkill tough but if you think that's worth it, it shouldn't be too hard
See #7373 (comment) for prior discussion
Fixes helix not redrawing after receiving messages from the LSP by replacing the existing (buggy) special-purpose deboucing with using the redraw handle that was added as part of #3890