Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Nord theme to follow the Nord style guide #7490

Merged
merged 1 commit into from
Jul 9, 2023
Merged

Update the Nord theme to follow the Nord style guide #7490

merged 1 commit into from
Jul 9, 2023

Conversation

sharpenedblade
Copy link
Contributor

This rewrites the entire Nord theme to make it follow the upstream style guide. The current Nord theme does not follow the style guide and also does not look like any of the official ports. The nord.vim port was used as a guide when the nord style guide was unclear. This looks much more similar to the other Nord ports, and also improves the
contrast of code compared to the old theme.

helix_nord_theme_comparison

This rewrites the entire Nord theme to make it follow the upstream
style guide. The current Nord theme does not follow the style guide
and also does not look like any of the official ports. The nord.vim
theme was used as a guide when the nord style guide was unclear. This
looks much more similar to the other Nord ports, and also improves the
contrast of code compared to the old theme. This change only affects
the dark version of the theme.
@the-mikedavis the-mikedavis added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Jun 30, 2023
@pascalkuthe pascalkuthe merged commit c33795e into helix-editor:master Jul 9, 2023
6 checks passed
@sharpenedblade sharpenedblade deleted the update-nord-theme branch July 12, 2023 07:33
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants