Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP: Key diagnostics off file path instead of URI #7367

Merged
merged 2 commits into from
Feb 25, 2024
Merged

LSP: Key diagnostics off file path instead of URI #7367

merged 2 commits into from
Feb 25, 2024

Commits on Jan 29, 2024

  1. LSP: Key diagnostics off file path instead of URI 

    URIs need to be normalized to be comparable. For example a language
server could send a URI for a path containing '+' as '%2B' but we might
encode this in something like 'Document::url' as just '+'. We can
normalize the URI straight into a PathBuf though since this is the only
value we compare these diagnostics URIs against. This also covers
edge-cases like windows drive letter capitalization.
    @the-mikedavis
    the-mikedavis committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    7ea16ad View commit details
    Browse the repository at this point in the history

  2. LSP: Normalize diagnostic file paths

    @the-mikedavis
    the-mikedavis committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    fbd31db View commit details
    Browse the repository at this point in the history