Fix style overwriting in table rows with multiple cells #7281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for a subtle bug in the styling of cells in a table: only the last Cell in the selected Row will display fuzzy-matching highlights. The simplest way to reproduce the bug is to open up the buffer picker. Inputting a buffer ID number or a flag which is present like * should highlight matched characters with your theme's 'ui.text.focus' scope, but the styles are not applied. The issue is that the block moved in this commit was called per-cell but operates on the whole row's area, so the call in the last cell would overwrite all prior cells. The block must be moved outside the for-loop over the cells.
the-mikedavis
added
C-bug
the-mikedavis
force-pushed
the
fix-table-style-overwriting
branch
from
e2567cb
to
13259b0
Compare
Triton171
pushed a commit
to Triton171/helix
that referenced
this pull request
Jun 18, 2023
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for a subtle bug in the styling of cells in a table: only the last Cell in the selected Row will display fuzzy-matching highlights.
The simplest way to reproduce the bug is to open up the buffer picker. Inputting a buffer ID number or a flag which is present like * should highlight matched characters with your theme's 'ui.text.focus' scope, but the styles are not applied.
The issue is that the block moved in this commit was called per-cell but operates on the whole row's area, so the call in the last cell would overwrite all prior cells. The block must be moved outside the for-loop over the cells.