Fix off-by-one in select symbol references #7132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dead10ck
approved these changes
May 25, 2023
aotarola
pushed a commit
to aotarola/helix
that referenced
this pull request
May 28, 2023
aotarola
pushed a commit
to aotarola/helix
that referenced
this pull request
May 28, 2023
Triton171
pushed a commit
to Triton171/helix
that referenced
this pull request
Jun 18, 2023
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
mtoohey31
added a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request fixes an off-by-one error in
select_references_to_symbol_under_cursor.When finding the range which contains the head of the current primary selection (so that this range will be the new primary selection), using the
headfield of the primary selection leads to the correct range being missed whenhead > anchorand the cursor is on the final character of the range, sinceRange::contains'sposparameter seems to refer to the position of a character since it is non-inclusive. Using thecursormethod fixes this since it returns the position of the character under the cursor.