Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command expansions %key{body} #6979

Closed
wants to merge 23 commits into from
Closed

Add command expansions %key{body} #6979

wants to merge 23 commits into from

Commits on Jan 19, 2024

  1. Add command expansions %key{body} 

    Based on: helix-editor#3393

---

Squashed commit of the following:

commit 4e16272eb27fde410022785ffcdb6828ac61aee9
Merge: 07b109d 5ae30f1
Author: Jesús R <[email protected]>
Date:   Sat May 6 07:56:28 2023 -0600

    Merge branch 'master' into cmd-expansions

commit 07b109d
Author: Jesús R <[email protected]>
Date:   Mon Apr 24 19:14:58 2023 -0600

    fix: Not parsing sh body

commit 8bf040f
Author: Jesús R <[email protected]>
Date:   Sat Apr 22 22:46:17 2023 -0600

    Use %key{body}

commit f6fea44
Merge: ffb40de b7c62e2
Author: Jesús R <[email protected]>
Date:   Sat Apr 22 17:34:07 2023 -0600

    Merge branch 'master' into cmd-expansions

commit ffb40de
Merge: 2be5d34 b9b4ed5
Author: Jesús R <[email protected]>
Date:   Tue Apr 11 15:48:15 2023 -0600

    Merge branch 'master' into cmd-expansions

commit 2be5d34
Author: Jesús R <[email protected]>
Date:   Tue Apr 11 15:46:58 2023 -0600

    Use #{} for variables and #key [] for commands

commit 7e7c0dc
Merge: 22d17f9 531b745
Author: Bob <[email protected]>
Date:   Wed Apr 5 09:11:13 2023 +0800

    Merge branch 'master' into cmd-expansions

commit 22d17f9
Author: Bob <[email protected]>
Date:   Thu Jan 26 09:43:13 2023 +0800

    Update helix-term/src/commands/typed.rs

    Co-authored-by: Ivan Tham <[email protected]>

commit 85d38a7
Author: Bob Qi <[email protected]>
Date:   Tue Jan 24 14:49:16 2023 +0800

    remove command group function

commit 784380f
Merge: 6f6cb3c 64ec025
Author: Bob Qi <[email protected]>
Date:   Tue Jan 24 14:42:31 2023 +0800

    Merge remote-tracking branch 'origin/master'

commit 6f6cb3c
Author: Bob Qi <[email protected]>
Date:   Mon Nov 21 10:39:52 2022 +0800

    support commmand expansion
    @ksdrar
    ksdrar committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    f7cdf69 View commit details
    Browse the repository at this point in the history

  2. Add some requested changes

    @ksdrar
    ksdrar committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    aca7d51 View commit details
    Browse the repository at this point in the history

  3. Change "filedir" to "dirname"

    @ksdrar
    ksdrar committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    e6801c8 View commit details
    Browse the repository at this point in the history

  4. Use standalone implementation for %sh{}

    @ksdrar
    ksdrar committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    8b1aa90 View commit details
    Browse the repository at this point in the history

  5. Move expand_args() to helix_view::editor

    @ksdrar
    ksdrar committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    f54ef6b View commit details
    Browse the repository at this point in the history

  6. Add requested changes

    @ksdrar
    ksdrar committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    66ddd23 View commit details
    Browse the repository at this point in the history

  7. Put variable expansion in its own module

    @ksdrar
    ksdrar committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    d360ac6 View commit details
    Browse the repository at this point in the history

  8. Fail typed command if variable expansion fails

    @ksdrar
    ksdrar committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    cf64b25 View commit details
    Browse the repository at this point in the history

  9. Add unit tests

    @ksdrar
    ksdrar committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    c474611 View commit details
    Browse the repository at this point in the history

  10. Format with cargo fmt

    @ksdrar
    ksdrar committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    4f7413d View commit details
    Browse the repository at this point in the history

  11. Change expansion method

    @ksdrar
    ksdrar committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    3bf311a View commit details
    Browse the repository at this point in the history

  12. Trim shell output in variable expansion

    @ksdrar
    ksdrar committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    1543a26 View commit details
    Browse the repository at this point in the history

  13. Merge mapable command args before expanding

    @ksdrar
    ksdrar committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    49fce83 View commit details
    Browse the repository at this point in the history

  14. Split args before executing the command

    @ksdrar
    ksdrar committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    c0105aa View commit details
    Browse the repository at this point in the history

  15. Add basename and selection variables

    @ksdrar
    ksdrar committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    c710ff4 View commit details
    Browse the repository at this point in the history

  16. Add integration tests

    @ksdrar
    ksdrar committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    406fb08 View commit details
    Browse the repository at this point in the history

  17. Fix clippy lints

    @ksdrar
    ksdrar committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    ed4cf00 View commit details
    Browse the repository at this point in the history

  18. Use cwd when no buffer is open

    @ksdrar
    ksdrar committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    77d26cb View commit details
    Browse the repository at this point in the history

  19. Test for empy editor and follow /var symlink

    @ksdrar
    ksdrar committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    28372db View commit details
    Browse the repository at this point in the history

  20. Add echo command. Add %{cwd}

    @ksdrar
    ksdrar committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    f38a26b View commit details
    Browse the repository at this point in the history

  21. Generate docs and use helix's canonicalize

    @ksdrar
    ksdrar committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    f2672bf View commit details
    Browse the repository at this point in the history

  22. Make requested changes and add usage docs

    @ksdrar
    ksdrar committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    778db9b View commit details
    Browse the repository at this point in the history

  23. main cursor to primary cursor

    @ksdrar
    ksdrar committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    efe6aef View commit details
    Browse the repository at this point in the history