Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GN language support #6969

Merged
merged 7 commits into from
Nov 18, 2023
Merged

GN language support #6969

merged 7 commits into from
Nov 18, 2023

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented May 4, 2023

Thanks to @willcassella for doing the actual work here.

Comments in the query files indicate some things aren't quite right, but it works well enough for me.

Fixes #6968

runtime/queries/gn/highlights.scm Show resolved Hide resolved
runtime/queries/gn/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/gn/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/gn/locals.scm Show resolved Hide resolved
@kirawi kirawi added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels May 4, 2023
@the-mikedavis the-mikedavis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from a maintainer. labels May 4, 2023
@dnfield
Copy link
Contributor Author

dnfield commented May 4, 2023

Thanks for the quick review! The tree-sitter stuff is a bit new to me, I tried to fix it up.

@dnfield dnfield requested a review from the-mikedavis May 4, 2023 21:24
runtime/queries/gn/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/gn/locals.scm Outdated Show resolved Hide resolved
runtime/queries/gn/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/gn/highlights.scm Outdated Show resolved Hide resolved
@dnfield dnfield requested a review from the-mikedavis May 5, 2023 23:34
the-mikedavis
the-mikedavis previously approved these changes May 6, 2023
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 6, 2023
@dnfield
Copy link
Contributor Author

dnfield commented Nov 2, 2023

Should I resolve the conflicts? Will this be accepted?

@the-mikedavis
Copy link
Member

I think this is a good addition - could you resolve the conflicts?

For context, GN here is google's ninja generator system it uses for chromium, right?

@dnfield
Copy link
Contributor Author

dnfield commented Nov 9, 2023

Yes, it's used with the ninja build system, which is used by Chromium, Flutter, Android, Skia (although some of those are moving more towards Bazel at this point).

@archseer archseer merged commit b306b25 into helix-editor:master Nov 18, 2023
6 checks passed
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GN language support
4 participants