-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor dracula theme #6552
Refactor dracula theme #6552
Conversation
I was thinking about doing this too. So the only thing I have to say is that the Dracula theme has a big community, then I recommend you to read the Dracula theme specification and maybe you can contribute there too. |
Nice, thank you!) |
I looked at the specs and I wanna say that I like the purple color (#BD93F9) of the variables instead of dracula's foreground color, for example)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to add yourself to the list of authors given that you modified this multiple times? So next time when I see your name there can just merge it.
If @loewenheim agrees with the changes I will merge it, haven't go through the specification.
Sure! Sounds great! |
I'm fine with the changes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending the PR.
Can you please resolve the conflicts? |
Resolved! |
I edited this from the browser on my smartphone and I didn't see the button to commit) |
@Chirikumbrah This is too much purple for me :( Thank you for your contribution, especially the selection color is better now, but I think that the main color should stay white. Sticking to the specification keeps things consistent :) |
@mo8it After using NvChad with its chadracula for a while I'm very used to the purple variables. So it seems natural for me :) But I'm agree with your words about consistency and I'll change the color of the variables to white! Thank you) |
You can create a new theme as modified dracula with more purple. That would make us both happy 😄 Again thank you for the changes, it is just the purple :) |
That's great idea. I'm thinkin' about it) |
I tried to make dracula scheme more comfortable.
normal color is now purple
insert cursor color is green now
and select is cyan now
selection colors are also changed
cursorline and statusline colors are lighter now
i changed some colors of variables, types and operators, so now they are nicer to the eyes, imho :)
diagnostic info color is cyan now
diagnostic warning is now yellow
there are also some changes that u can see in the commit info :)