Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dracula theme #6552

Merged
merged 3 commits into from
Apr 12, 2023

Conversation

Chirikumbrah
Copy link
Contributor

@Chirikumbrah Chirikumbrah commented Apr 2, 2023

I tried to make dracula scheme more comfortable.

image
normal color is now purple

image
insert cursor color is green now

image
and select is cyan now

image
image
selection colors are also changed

image
image
cursorline and statusline colors are lighter now

image
i changed some colors of variables, types and operators, so now they are nicer to the eyes, imho :)

image
diagnostic info color is cyan now

image
diagnostic warning is now yellow

there are also some changes that u can see in the commit info :)

@galearez
Copy link

galearez commented Apr 4, 2023

I was thinking about doing this too. So the only thing I have to say is that the Dracula theme has a big community, then I recommend you to read the Dracula theme specification and maybe you can contribute there too.

@Chirikumbrah
Copy link
Contributor Author

Nice, thank you!)
I'll do some changes according to the specifications)

@Chirikumbrah
Copy link
Contributor Author

I looked at the specs and I wanna say that I like the purple color (#BD93F9) of the variables instead of dracula's foreground color, for example))
I'm not going to change anything for now)
But i'm opened to interesting suggestions)
I'll also see what I can bring to our beloved Dracula))

Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add yourself to the list of authors given that you modified this multiple times? So next time when I see your name there can just merge it.

If @loewenheim agrees with the changes I will merge it, haven't go through the specification.

@Chirikumbrah
Copy link
Contributor Author

Chirikumbrah commented Apr 4, 2023

Sure! Sounds great!
Thank you)

@loewenheim
Copy link
Contributor

I'm fine with the changes :)

pickfire
pickfire previously approved these changes Apr 6, 2023
Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending the PR.

@pickfire
Copy link
Contributor

pickfire commented Apr 6, 2023

Can you please resolve the conflicts?

@Chirikumbrah
Copy link
Contributor Author

Resolved!
Thanks)

@Chirikumbrah
Copy link
Contributor Author

Can you please resolve the conflicts?

I edited this from the browser on my smartphone and I didn't see the button to commit)
It should be ok now)

@the-mikedavis the-mikedavis changed the title Attempt to refactor dracula theme Refactor dracula theme Apr 12, 2023
@the-mikedavis the-mikedavis merged commit f6d65cf into helix-editor:master Apr 12, 2023
@mo8it
Copy link
Contributor

mo8it commented Apr 12, 2023

@Chirikumbrah This is too much purple for me :(

Thank you for your contribution, especially the selection color is better now, but I think that the main color should stay white.

Sticking to the specification keeps things consistent :)

@mo8it
Copy link
Contributor

mo8it commented Apr 12, 2023

image

Too much purple which is not a neutral color to me :(

@Chirikumbrah
Copy link
Contributor Author

Chirikumbrah commented Apr 15, 2023

@mo8it After using NvChad with its chadracula for a while I'm very used to the purple variables. So it seems natural for me :)

But I'm agree with your words about consistency and I'll change the color of the variables to white!

Thank you)

@mo8it
Copy link
Contributor

mo8it commented Apr 15, 2023

You can create a new theme as modified dracula with more purple. That would make us both happy 😄

Again thank you for the changes, it is just the purple :)

@Chirikumbrah
Copy link
Contributor Author

Chirikumbrah commented Apr 15, 2023

You can create a new theme as modified dracula with more purple.

That's great idea. I'm thinkin' about it)

Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants