Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenCL tree-sitter and LSP config #6473

Merged
merged 5 commits into from
Apr 12, 2023
Merged

Add OpenCL tree-sitter and LSP config #6473

merged 5 commits into from
Apr 12, 2023

Conversation

lefp
Copy link
Contributor

@lefp lefp commented Mar 29, 2023

No description provided.

the-mikedavis
the-mikedavis reviewed Mar 29, 2023
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could re-use C or C++ for the syntax highlighting. See #4242 as a good example

@lefp
Copy link
Contributor Author

lefp commented Mar 29, 2023 •
edited
Loading

We could re-use C or C++ for the syntax highlighting. See #4242 as a good example

Thanks for the example; I've done that for now.
I'd like to modify the C grammar to better match OpenCL (at least to update the keywords and built-in types; e.g. the parser currently sees kernel as a type because it isn't a keyword), but I don't know how long that will take me. I've only started learning about treesitter yesterday.

@lefp lefp marked this pull request as draft March 30, 2023 02:47
@lefp
Copy link
Contributor Author

lefp commented Mar 30, 2023

I'd like to modify the C grammar to better match OpenCL.

I think I can have an acceptable version within about a week. I've set the pull request status to Draft in the meantime.

@lefp lefp changed the title Add OpenCL LSP Add OpenCL LSP+grammar Mar 30, 2023
@lefp lefp marked this pull request as ready for review March 30, 2023 20:21
@the-mikedavis the-mikedavis changed the title Add OpenCL LSP+grammar Add OpenCL tree-sitter and LSP config Apr 12, 2023
@the-mikedavis the-mikedavis merged commit fff8543 into helix-editor:master Apr 12, 2023
Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
@lefp @Triton171
Add OpenCL tree-sitter and LSP config (helix-editor#6473)
a210ec7
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
@lefp @wes-adams
Add OpenCL tree-sitter and LSP config (helix-editor#6473)
97f4291
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@lefp
Add OpenCL tree-sitter and LSP config (helix-editor#6473)
d4d9d5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lefp @the-mikedavis