Update onelight theme #6192
Merged
Update onelight theme #6192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runtime/themes/onelight.toml
Outdated
| "ui.cursor.normal" = { fg = "white", bg = "grey" } | ||
| "ui.cursor.insert" = { fg = "white", bg = "grey" } | ||
| "ui.cursor.select" = { fg = "white", bg = "grey" } | ||
| "ui.cursor.match" = { bg = "light-grey" } |
There was a problem hiding this comment.
It looks like this isn't defined in the palette. Maybe this could use one of the grey-* shades?
There was a problem hiding this comment.
Thanks for the review, here is a change to light-white, because the multi-cursor uses the grey style, here only do grayscale and multi-cursor style to distinguish.
the-mikedavis
added
A-theme
Co-authored-by: Michael Davis <[email protected]>
the-mikedavis
approved these changes
Mar 6, 2023
sagnibak
pushed a commit
to sagnibak/helix
that referenced
this pull request
Mar 21, 2023
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset the keyword section to complete most of the highlighting colors.
wiki has update.