Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty print the minified logo.svg #5941

Closed

Conversation

goyalyashpal
Copy link
Contributor

@goyalyashpal goyalyashpal commented Feb 12, 2023

I have not changed anything else in the logo, just

  • automatic pretty print using Notepad++ XML plugin initially,
  • then manual pretty print by hand
  • then trim trailing spaces in vscodium

It's weird that

  • github doesn't provide option to "diff" the images in its "rich diff" lol
  • only "2-up", "swipe", "onion"
  • gitlab has it since several months already.

image


2023-12-18:
Seeing how other applications (like tomcat) pretty print their user facing source files distribution (like "examples" codes) to keep the size low:

  • they use tabs \t for indentation, so, 1 character instead of 4 (or even 2) reduces things by lot.
  • other than that, the indentation can start from level 2. as xml's have only single element at root (level zero), so, even level 1 child are kept unindented.

@goyalyashpal goyalyashpal marked this pull request as draft February 12, 2023 06:10
@goyalyashpal goyalyashpal marked this pull request as ready for review February 12, 2023 06:13
@archseer
Copy link
Member

archseer commented Feb 13, 2023

The browser can pretty print the representation for you, and if you're actively working on the file it's always possible to pretty-print it before-hand. We deliberately provide a minimized representation to save on filesize since users are likely to just download the file and reuse it.

@goyalyashpal
Copy link
Contributor Author

goyalyashpal commented Feb 13, 2023

  • yes i perfectly agree that users likely wont care about it
  • i dont think there is any significant save in filesize as its just say 29*8 roughly 240 space characters more...
  • but yeah, its a cosmetic change anyway...

i felt it feels more polished to read and quickly analyse


2023.03.21: Luke Smith's rant about minified CSS lol, & Terry Caldwell's How To Unminify A CSS File

@goyalyashpal
Copy link
Contributor Author

u can close this if merging is not wanted

@the-mikedavis
Copy link
Member

I agree with archseer. I don't see much benefit in formatting SVGs in general, manually reading and editing any complicated SVG is not really productive if possible at all. Plus I don't think we want to make changes the logo any time soon

@goyalyashpal goyalyashpal deleted the logo-pretty-print branch February 14, 2023 02:10
@goyalyashpal goyalyashpal restored the logo-pretty-print branch February 14, 2023 02:10
@goyalyashpal goyalyashpal deleted the logo-pretty-print branch February 14, 2023 02:15
@goyalyashpal goyalyashpal changed the title Pretty print the logo.svg Pretty print the minified logo.svg Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants