Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language support for Angular #5607

Closed
wants to merge 1 commit into from
Closed

Language support for Angular #5607

wants to merge 1 commit into from

Conversation

hunterliao29
Copy link
Contributor

close #4861

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Jan 20, 2023
@the-mikedavis the-mikedavis self-requested a review January 20, 2023 15:54
the-mikedavis
the-mikedavis requested changes Jan 21, 2023
View reviewed changes
languages.toml
scope = "source.angular"
roots = ["angular.json"]
language-server = { command = "ngserver", args = ["--stdio", "--tsProbeLocations", "$(npm -g root)", "--ngProbeLocations", "$(npm -g root)"] }
file-types = ["ts", "html"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will conflict with the typscript and html file-types: all .ts and .html files will become angular and will use this language server configuration. See #3249

@hunterliao29
Copy link
Contributor Author

I think this is not feasible due to the limitation.
#2507 to use angular, typescript, html, css language server.
#3249 to set file type
And need to have option to set language server base on file type.

@danriedl
Copy link

Hey @hunterliao29, asking in favor of #4861.
As we do have now support for multiple language-servers could we reopen this, to get angular support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis requested changes

Assignees
No one assigned
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Angular support
3 participants
@hunterliao29 @danriedl @the-mikedavis