Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more file-types for python #5593

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

nabaco
Copy link
Contributor

@nabaco nabaco commented Jan 19, 2023

@Eloitor
Copy link
Contributor

Eloitor commented Jan 19, 2023

Could .sage be temporally added as a python file? The syntax of a sage file is basically the same as python. The only difference is that there are more build-in functions.

@gabydd
Copy link
Member

gabydd commented Jan 19, 2023

Apparently python language servers might not work the best with sage see https://ask.sagemath.org/question/50654/lsp-language-server-protocol-support-for-sagemath/ I would suggest making a new pr spacifically for sage support instead and test out how well the grammar and language servers work

@the-mikedavis
Copy link
Member

I'm not familiar with sage but we do something similar for starlark which is python-like: it's a separate language entry but it re-uses the python tree-sitter parser and queries #2903

@the-mikedavis the-mikedavis merged commit 94ef6fb into helix-editor:master Jan 19, 2023
@nabaco nabaco deleted the python-filetypes branch January 19, 2023 19:53
kirawi pushed a commit to kirawi/helix that referenced this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants