Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eb word selection trick to the tutor #5247

Merged
merged 1 commit into from
Dec 24, 2022
Merged

Add eb word selection trick to the tutor #5247

merged 1 commit into from
Dec 24, 2022

Conversation

matklad
Copy link
Contributor

@matklad matklad commented Dec 21, 2022

Maybe this is obvious, but it took me several days to google this up :-)

@gabydd
Copy link
Member

gabydd commented Dec 21, 2022

Just a thought in some cases eb can sometimes be better for this because it won't select the whitespace between words also miw is definitely the more intuitive keybinding though it is more keys to type.

the-mikedavis
the-mikedavis reviewed Dec 21, 2022
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like having an example for w/b/e for selecting words 👍

Finding a place for it will be a little tricky though: each tutor section has a constant height of 19 rows and this currently makes ch 3.2 too tall

@Omnikar
Copy link
Contributor

Omnikar commented Dec 23, 2022

We could give the extra stuff the space of one full other page, so that the uniformity is maintained.

@matklad
Copy link
Contributor Author

matklad commented Dec 24, 2022

What about this version? This also gives space to add an example for WORDS, which I think might be useful for people not already familiar with vim.

@kirawi kirawi added A-documentation Area: Documentation improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Dec 24, 2022
the-mikedavis
the-mikedavis approved these changes Dec 24, 2022
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!

@the-mikedavis the-mikedavis changed the title Add wb word selection trick to the tutor Add eb word selection trick to the tutor Dec 24, 2022
@the-mikedavis the-mikedavis merged commit 1af76b7 into helix-editor:master Dec 24, 2022
@matklad matklad deleted the wb branch December 24, 2022 22:30
@matklad matklad mentioned this pull request Dec 24, 2022
Closed
@matklad
Copy link
Contributor Author

matklad commented Dec 24, 2022

Filed #5284 which sounds like a good E-good-first-issue.

hadronized pushed a commit to hadronized/helix that referenced this pull request Jan 4, 2023
@matklad @hadronized
Add eb word selection trick to the tutor (helix-editor#5247)
25ebbca
freqmod pushed a commit to freqmod/helix that referenced this pull request Feb 8, 2023
@matklad
Add eb word selection trick to the tutor (helix-editor#5247)
8e74f53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-documentation Area: Documentation improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matklad @gabydd @Omnikar @the-mikedavis @kirawi