Sort diagnostics by severity in diagnostics picker #5026
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
added
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually as a developer you want to fix errors first and then warnings, so let's show errors first in diagnostic picker.
When sorting I use
lsp::DiagnosticSeverity::HINTas a default value in case a diagnostic doesn't have a severity. Initially I was trying to make the lowest severity possible usinglsp::DiagnosticSeverity's constructor but it's private.While preparing a PR I thought that behaviour of
[dand]dmust also be consistent with that in the picker. Currently this is not the case. Therefore I'll make this PR as a draft to gather feedback.Closes #3543