Fix x behavior on empty lines
#4847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirawi
added
A-helix-term
archseer
reviewed
Nov 25, 2022
| @@ -54,6 +54,9 @@ pub struct Range { | |||
| /// The head of the range, moved when extending. | |||
| pub head: usize, | |||
| pub horiz: Option<u32>, | |||
| /// True if range is intended to contain whole lines (e.g. after `line_extend_below`). | |||
| /// Useful to prevent first `line_extend_below` on an empty line selecting the next line. | |||
| pub line_mode: bool, | |||
There was a problem hiding this comment.
This should be a field on the Selection, not Range?
There was a problem hiding this comment.
I have no idea. :) . Seem to work OK for me, AFAICT.
dpc
force-pushed
the
fix-x
branch
2 times, most recently
from
e5cfc16
to
36889bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address my personal issue with #356.
I'm not sure if this is an ideal implementation, or will it get merged, but was easy enough and it should be easy for me to use a personal fork, just like I used to for kakoune: https://github.com/dpc/kakoune-dpc/