Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle language server termination #4797

Merged
merged 1 commit into from
Nov 19, 2022

Commits on Nov 18, 2022

  1. Handle language server termination

    This change handles a language server exiting. This was a UX sore-spot:
    if a language server crashed, Helix did not recognize the exit and
    continued to send requests to it. All requests would timeout since they
    would not receive responses. This would also hold-up Helix closing
    itself down since it would try to gracefully shutdown the server which
    is implemented in the LSP spec as a request.
    
    We could attempt to automatically restart the language server on crash.
    I left this for future work since that change will need to be slightly
    complicated: it will need to cover the case of a language server
    repeatedly crashing.
    the-mikedavis committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    fe97e19 View commit details
    Browse the repository at this point in the history