Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error! on unknown CompletionItemKind #4658

Merged
merged 3 commits into from
Nov 8, 2022
Merged

error! on unknown CompletionItemKind #4658

merged 3 commits into from
Nov 8, 2022

Commits on Nov 8, 2022

  1. error! on unknown CompletionItemKind 

    Instead of panicking on an unknown CompletionItemKind,
`error!` it instead and return `""`.
    @Tefached95
    Tefached95 committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    8c171f9 View commit details
    Browse the repository at this point in the history

  2. Update helix-term/src/ui/completion.rs 

    No need to explicitly log CompletionItemKind

Co-authored-by: Michael Davis <[email protected]>
    @Tefached95 @the-mikedavis
    Tefached95 and the-mikedavis committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    24e6cc7 View commit details
    Browse the repository at this point in the history

  3. Appease linter by removing final ,

    @Tefached95
    Tefached95 committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    64767e5 View commit details
    Browse the repository at this point in the history