Don't panic if we get an unexpected key code #4576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
It seems like we get media play/pause/mute/etc keys despite not emitting DISAMBIGUATE_ESCAPE_CODES(helix-editor#4125). Make crossterm::event::KeyCode a TryInto for KeyCode instead of Into to let us ignore keys we don't care about.
groves
force-pushed
the
no-unknown-key-panic
branch
from
f35d2c9
to
70286ff
Compare
Closed
| @@ -155,9 +157,9 @@ impl From<crossterm::event::KeyCode> for KeyCode { | |||
| | CKeyCode::Menu | |||
| | CKeyCode::KeypadBegin | |||
| | CKeyCode::Media(_) | |||
| | CKeyCode::Modifier(_) => unreachable!( | |||
| | CKeyCode::Modifier(_) => bail!( | |||
| "Shouldn't get this key without enabling DISAMBIGUATE_ESCAPE_CODES in crossterm" | |||
There was a problem hiding this comment.
Suggested change
| "Shouldn't get this key without enabling DISAMBIGUATE_ESCAPE_CODES in crossterm" | |
| "Shouldn't get key {:?} without enabling DISAMBIGUATE_ESCAPE_CODES in crossterm", | |
| val |
Since the unreachable doesn't point at this line anymore, this should make it easier to debug if it shows up in the logfile
|
Rather than turning this into a |
kirawi
added
A-helix-term
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like we get media play/pause/mute/etc keys despite not emitting DISAMBIGUATE_ESCAPE_CODES(#4125).
Make crossterm::event::KeyCode a TryInto for KeyCode instead of Into to let us ignore keys we don't care about.