Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rainbow indentation guides #4493

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SoraTenshi
Copy link
Contributor

Since the last PR is kind of broken, check PR #4056 for more info.

@kirawi kirawi added A-gui Area: Helix gui improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Oct 31, 2022
@yavko
Copy link

yavko commented Jan 27, 2023

Anyone up for reviewing? I and, I bet many others would greatly appreciate it! Thanks in-case someone does!

@SoraTenshi
Copy link
Contributor Author

Anyone up for reviewing? I and, I bet many others would greatly appreciate it! Thanks in-case someone does!

This review kinda depends on the rainbow bracket PR, as i am using the same mechanism to get rainbow colours.
So until the Rainbow Bracket PR isn't quite 'ready', there is no point in reviewing it just now.

@yavko
Copy link

yavko commented Jan 27, 2023

Anyone up for reviewing? I and, I bet many others would greatly appreciate it! Thanks in-case someone does!

This review kinda depends on the rainbow bracket PR, as i am using the same mechanism to get rainbow colours. So until the Rainbow Bracket PR isn't quite 'ready', there is no point in reviewing it just now.

Ah thanks for clarifying!

@SoraTenshi
Copy link
Contributor Author

Just linking the PR to the rainbow brackets here as a sort of dependency tracker:
#2857

@sudormrfbin sudormrfbin added the S-waiting-on-pr Status: This is waiting on another PR to be merged first label Jan 30, 2023
This change adds a field to the schema of themes which takes a
list of styles.

    rainbow = ["red", "orange", "yellow", { modifiers = ["reversed"] }]
    [palette]
    red = "#ff0000"
    orange = "#ffa500"
    yellow = "#fff000"

Normal style rules apply for each element in `rainbows`: you can
use definitions from the palette and the full fg/bg/modifiers
notation.

Themes written with `rainbow` keys are not backwards compatible.
Parsing errors will be generated for older versions of Helix
attempting to use themes with `rainbow` keys.

A default rainbow is provided with base16 colors.

This change is made with rainbow pair characters (parens, brackets, etc.)
in mind but it could also be used for other rainbow cosmetic elements
like rainbow indent-guides.
@SoraTenshi SoraTenshi force-pushed the colored-indent-guides branch 2 times, most recently from 44a57c6 to ea58a7a Compare February 12, 2023 21:25
@SoraTenshi
Copy link
Contributor Author

Closes #4010

(for tracking purposes)

omentic added a commit to omentic/helix that referenced this pull request Jul 16, 2023
@musjj
Copy link

musjj commented Oct 9, 2023

Just asking, but can this option can be used for highlighting the active indent guide and dimming the others? Like this:

image

@SoraTenshi
Copy link
Contributor Author

Just asking, but can this option can be used for highlighting the active indent guide and dimming the others? Like this:

image

That's not part of this PR.

@musjj
Copy link

musjj commented Oct 9, 2023

I see, if so I think that #4010 should not be closed. The issue specifically mentions:

Indent guides should look smoother and highlighted depending on the currently focused paragraph.

omentic added a commit to omentic/helix-ext that referenced this pull request Nov 1, 2023
omentic pushed a commit to omentic/helix-ext that referenced this pull request May 1, 2024
omentic pushed a commit to omentic/helix-ext that referenced this pull request May 1, 2024
omentic pushed a commit to omentic/helix-ext that referenced this pull request May 1, 2024
omentic pushed a commit to omentic/helix-ext that referenced this pull request May 1, 2024
omentic pushed a commit to omentic/helix-ext that referenced this pull request May 1, 2024
omentic pushed a commit to omentic/helix-ext that referenced this pull request May 1, 2024
omentic pushed a commit to omentic/helix-ext that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-gui Area: Helix gui improvements S-waiting-on-pr Status: This is waiting on another PR to be merged first S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants