-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(view): global status line option #4417
Conversation
e011f77
to
26a708e
Compare
9ecc14c
to
2ec0b75
Compare
@CBenoit could you adjust the label to “waiting-on-review” pleas? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not really familiar enough with the rendering code to have a confident judgment on this PR, but from what I can tell, this change looks good to me. It's surprisingly small.
From what I can tell, is it basically just hiding the individual status lines, or does it actually prevent them from rendering in the first place?
Great work @matoous , I love using a single status line! Don't we also need something equivalent to neovim's Here's an screenshot of what I mean, latest neovim with I just feel these 2 features belong together. But maybe this should be in a separate PR? Let me know your thoughts! |
2ec0b75
to
a51d967
Compare
@dahmc I am sorry, I am not sure if I understand. The filename of the document in currently active window is displayed in the status line. Furthermore, there's bufferline for buffers. I am not sure how else we could display the filename withing single status line. |
Add option to render single glboal status line instead of rendering status line per view. Fixes: helix-editor#2254
a51d967
to
ea31a5b
Compare
@matoous The filename for the currently active buffer is shown in the status line, correct. What I'm referring to is that we now don't know what the filename of the other buffer is, until we switch to it. The bufferline doesn't really help here, because there could be 10 open buffers, and it's now clear what the filename of the inactive buffer is exactly. Does that make sense? :) |
@dahmc understood. Yet, I am not sure how that would be solved if we have single status line. Maybe a configuration option for bufferline would do? If you want to see the filename for all open views then I don’t think singular status line would work. |
@matoous Yeah I think the only way to make this work would be how it's done in neovim what I've shown in my screenshot above, using something like a winbar, which sits below the buffer line |
may I ask if I can try to take over this since this PR is almost one year old now? |
@TornaxO7 sure, feel free to. |
Ok, so would it e fine, if I only focus on the statusline? |
Closing in favor of @TornaxO7 's PR. |
Add option to render single global status line instead of rendering status line per view.
With
(default)
with
Fixes: #2254