Add goto_url (gu) command #4398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dead10ck
reviewed
Oct 21, 2022
| use helix_lsp::Url; | ||
|
|
||
| let (view, doc) = current_ref!(cx.editor); | ||
| let selection = doc.selection(view.id).primary(); |
There was a problem hiding this comment.
This is actually a range; could we change this name to range?
| let text = if selection.to() - selection.from() == 1 { | ||
| let current_word = movement::move_next_long_word_start( | ||
| text.slice(..), | ||
| movement::move_prev_long_word_start(text.slice(..), selection, 1), |
There was a problem hiding this comment.
It might be a little clearer if this were in its own variable.
| @@ -1079,6 +1079,12 @@ impl Editor { | |||
| self._refresh(); | |||
| } | |||
|
|
|||
| pub fn open_url(&mut self, url: lsp::Url) { | |||
There was a problem hiding this comment.
This could probably just all go into the command. I'm not sure I understand why this is an Editor function.
| @@ -43,6 +43,8 @@ log = "~0.4" | |||
|
|
|||
| which = "4.2" | |||
|
|
|||
| open = "3" | |||
There was a problem hiding this comment.
The maintainers might be wary of pulling in a crate for just this command.
| text.slice(selection.from()..selection.to()).to_string() | ||
| }; | ||
|
|
||
| match Url::parse(&text) { |
There was a problem hiding this comment.
Is there a reason to parse a URL? What happens if you run this command with some arbitrary text?
| @@ -195,6 +195,7 @@ Jumps to various locations. | |||
| | `g` | Go to line number `<n>` else start of file | `goto_file_start` | | |||
| | `e` | Go to the end of the file | `goto_last_line` | | |||
| | `f` | Go to files in the selection | `goto_file` | | |||
| | `u` | Go to url in the selection | `goto_url` | | |||
There was a problem hiding this comment.
It would be clearer if this explicitly mentioned that it will open the URL in a web browser.
|
Why do we need a second command for this? Couldn't |
kirawi
added
A-helix-term
pascalkuthe
added
S-inactive
matoous
added a commit
to matoous/helix
that referenced
this pull request
Feb 4, 2023
Add capability for `goto_file` command to open an URL under cursor. Fixes: helix-editor#1472 Superseds: helix-editor#4398
matoous
added a commit
to matoous/helix
that referenced
this pull request
Feb 4, 2023
Add capability for `goto_file` command to open an URL under cursor. Fixes: helix-editor#1472 Superseds: helix-editor#4398
matoous
added a commit
to matoous/helix
that referenced
this pull request
Feb 4, 2023
Add capability for `goto_file` command to open an URL under cursor. Fixes: helix-editor#1472 Superseds: helix-editor#4398
matoous
added a commit
to matoous/helix
that referenced
this pull request
Feb 4, 2023
Add capability for `goto_file` command to open an URL under cursor. Fixes: helix-editor#1472 Superseds: helix-editor#4398
matoous
added a commit
to matoous/helix
that referenced
this pull request
Mar 10, 2023
Add capability for `goto_file` command to open an URL under cursor. Fixes: helix-editor#1472 Superseds: helix-editor#4398
matoous
added a commit
to matoous/helix
that referenced
this pull request
Mar 31, 2023
Add capability for `goto_file` command to open an URL under cursor. Fixes: helix-editor#1472 Superseds: helix-editor#4398
matoous
added a commit
to matoous/helix
that referenced
this pull request
Mar 31, 2023
Add capability for `goto_file` command to open an URL under cursor. Fixes: helix-editor#1472 Superseds: helix-editor#4398
matoous
added a commit
to matoous/helix
that referenced
this pull request
May 24, 2023
Add capability for `goto_file` command to open an URL under cursor. Fixes: helix-editor#1472 Superseds: helix-editor#4398
matoous
added a commit
to matoous/helix
that referenced
this pull request
Nov 9, 2023
Add capability for `goto_file` command to open an URL under cursor. Fixes: helix-editor#1472 Superseds: helix-editor#4398
matoous
added a commit
to matoous/helix
that referenced
this pull request
Nov 19, 2023
Add capability for `goto_file` command to open an URL under cursor. Fixes: helix-editor#1472 Superseds: helix-editor#4398
pascalkuthe
pushed a commit
that referenced
this pull request
Nov 21, 2023
matoous
added a commit
to matoous/helix
that referenced
this pull request
Nov 21, 2023
Add capability for `goto_file` command to open an URL under cursor. Fixes: helix-editor#1472 Superseds: helix-editor#4398
|
@pascalkuthe This can be closed now #5820 was merged. |
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
* feat(commands): open urls with goto_file command Add capability for `goto_file` command to open an URL under cursor. Fixes: helix-editor#1472 Superseds: helix-editor#4398 * open files inside helix * address code review * bump deps * fix based on code review comments
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
* feat(commands): open urls with goto_file command Add capability for `goto_file` command to open an URL under cursor. Fixes: helix-editor#1472 Superseds: helix-editor#4398 * open files inside helix * address code review * bump deps * fix based on code review comments
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
* feat(commands): open urls with goto_file command Add capability for `goto_file` command to open an URL under cursor. Fixes: helix-editor#1472 Superseds: helix-editor#4398 * open files inside helix * address code review * bump deps * fix based on code review comments
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
* feat(commands): open urls with goto_file command Add capability for `goto_file` command to open an URL under cursor. Fixes: helix-editor#1472 Superseds: helix-editor#4398 * open files inside helix * address code review * bump deps * fix based on code review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
gucommand which opens URL (either selected or hovered).Closes #1472