Add LSP for groovy

[zephaniahong]

#4211
Hi! @the-mikedavis
I'm trying to implement LSP and syntax highlighting for groovy. The LSP sorta works though it seems a little slow. But my main problem is trying to implement syntax highlighting. I tried copying the entire highlights.scm and injections.scm from java just to test things out but even that did not work. Any advice?

Thank you!

[archseer]

There seems to be a separate grammar in development here? I'm not sure how different groovy is from Java https://github.com/codieboomboom/tree-sitter-groovy

[archseer]

This is hard coded to your setup and shouldn't be upstreamed in this way

[zephaniahong]

Yup! I'm just testing things out to get a better understanding. But the main issue is that, I can't get the syntax highlighting to work

[archseer]

Try using inherits instead in the same way this was done for purescript 2d958d6

[zephaniahong]

Tried it but still does not seem to work.
Checked the logs and I'm getting this error:
helix_core::syntax [ERROR] Could not parse queries for language "groovy". Are your grammars out of sync? Try running 'hx --grammar fetch' and 'hx --grammar build'. This query could not be parsed: QueryError { row: 78, column: 1, offset: 1256, message: "comment", kind: NodeType }

I've ensured that I've sync all my grammars by running the mentioned commands but I still get the same error

[archseer]

If you use tree-sitter-groovy then you need to write queries specific to that implementation and can't just reuse the Java ones.

[zephaniahong]

I see! I'll give that a shot.
I've changed the tree sitter back to Java and tried using inherits. Any advice on why that implementation does not work? I checked the logs and it did not produce any error. But there is no syntax highlighting. My worry is that if I can't even get groovy to work with something that is already working then I can't begin to work on the custom highlight queries.

The only way I've gotten syntax highlighting to work for groovy is by add the groovy file extension to the java language.

Thank you!

[the-mikedavis]

You either need to use grammar = "java" in the [[language]] block or use a tree-sitter-groovy parser - this will fail to load because we're expecting the parsing to expose symbols under the name tree_sitter_groovy but this parser uses tree_sitter_java:

helix/helix-loader/src/grammar.rs

Line 76 in 2457111

let language_fn_name = format!("tree_sitter_{}", name.replace('-', "_"));

[the-mikedavis]

We could probably raise this log level so it shows up in the log by default, as long as this doesn't start showing up in test output:

helix/helix-core/src/syntax.rs

Line 371 in 2457111

.map_err(|e| log::info!("{}", e))

[zephaniahong]

I see! I think I understand now(: Thanks!
Also, what do you mean by 'as long as this doesn't start showing up in test output'? Would changing it to log::warning!("{}", e) solve what you're saying?

[the-mikedavis]

Looking at the test suite, it isn't actually a problem. The integration tests will print log lines but there isn't an integration test where this returns Error

#4315

[the-mikedavis]

I don't think groovy is close enough to java syntax-wise to use tree-sitter-java

[zephaniahong]

Yupp! But I just wanted to play around to make sure I understood the mechanics of how things were working. Once I wrap my head around it, I'll swap it out with tree-sitter-groovy and write queries for it.