Add pull request template #4161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poliorcetics
force-pushed
the
4002-pr-template
branch
from
d29a781
to
c452018
Compare
SoraTenshi
reviewed
Jan 17, 2023
|
|
||
| ## Tasks (not applicable to all PRs) | ||
|
|
||
| If something is unneeded, just don't check it, if it was needed, either the CI or a reviewer will |
There was a problem hiding this comment.
Suggested change
| If something is unneeded, just don't check it, if it was needed, either the CI or a reviewer will | |
| If something is not required, just don't check it, if it was required, either the CI or a reviewer will |
i believe that required sounds a bit better in this context :)
|
|
||
| ## Questions | ||
|
|
||
| <!--- Do you have points you're not sure about ? Add them here ---> |
There was a problem hiding this comment.
Suggested change
| <!--- Do you have points you're not sure about ? Add them here ---> | |
| <!--- Do you have points you're not sure about? Add them here ---> |
|
I was in favor of a template but I've used them at work for a while now and now I'm not sure I really like them: they add a lot of boilerplate that obscures the actual description. I think it might be ok though to have a PR template that only includes an HTML comment that gives some pointers like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a Pull Request template will make it easier for new and repeat contributors to learn and
remember common tasks to do when creating a PR and for reviewers to know what the PR is about with
a quick look.
Closes #4002