-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support different kinds of underline rendering (updated) #4061
Merged
archseer
merged 14 commits into
helix-editor:master
from
pascalkuthe:undercurl-modifier
Oct 19, 2022
Merged
Support different kinds of underline rendering (updated) #4061
archseer
merged 14 commits into
helix-editor:master
from
pascalkuthe:undercurl-modifier
Oct 19, 2022
Commits on Oct 1, 2022
-
Support different kinds of underline rendering
Adds four new modifiers that can be used in themes: - undercurled - underdashed - underdotted - double-underline
Configuration menu - View commit details
-
Copy full SHA for 999b45b - Browse repository at this point
Copy the full SHA 999b45bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ad7d54 - Browse repository at this point
Copy the full SHA 3ad7d54View commit details -
Add underline field to doctests, and fix bugs
Configuration menu - View commit details
-
Copy full SHA for 79a39c1 - Browse repository at this point
Copy the full SHA 79a39c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for de72b9c - Browse repository at this point
Copy the full SHA de72b9cView commit details -
Detect extended underline support using terminfo
The cxterminfo crate has been used over popular alternatives like `term` since it supports querying for extended capabilities and also for it's small codebase size (which will make it easy to inline it into helix in the future if required).
Configuration menu - View commit details
-
Copy full SHA for 79d3d44 - Browse repository at this point
Copy the full SHA 79d3d44View commit details -
make underline_style a seperate option
Underline styles are mutally exclusive and overwrite each other. Therefore implementing as an modifier lead to incorrect behaviour when the underline style is overwritten. For backwards compatability the "underline" modified is retained (but deprecated). Instead the "underline_style" and "underline_color" optios should be used to style underlines.
Configuration menu - View commit details
-
Copy full SHA for 71ee589 - Browse repository at this point
Copy the full SHA 71ee589View commit details
Commits on Oct 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 114610f - Browse repository at this point
Copy the full SHA 114610fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bc324f - Browse repository at this point
Copy the full SHA 7bc324fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c36c06 - Browse repository at this point
Copy the full SHA 4c36c06View commit details
Commits on Oct 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ad0eb40 - Browse repository at this point
Copy the full SHA ad0eb40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f7088c - Browse repository at this point
Copy the full SHA 2f7088cView commit details
Commits on Oct 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 328c4d0 - Browse repository at this point
Copy the full SHA 328c4d0View commit details
Commits on Oct 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 963a0ac - Browse repository at this point
Copy the full SHA 963a0acView commit details
Commits on Oct 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 66a4908 - Browse repository at this point
Copy the full SHA 66a4908View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.