Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different kinds of underline rendering (updated) #4061

Merged
merged 14 commits into from
Oct 19, 2022

Commits on Oct 1, 2022

  1. Support different kinds of underline rendering

    Adds four new  modifiers that can be used in themes:
    
    - undercurled
    - underdashed
    - underdotted
    - double-underline
    sudormrfbin authored and pascalkuthe committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    999b45b View commit details
    Browse the repository at this point in the history
  2. Add separate color for underlines

    A-Walrus authored and pascalkuthe committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    3ad7d54 View commit details
    Browse the repository at this point in the history
  3. Fix failing tests

    Add underline field to doctests, and fix bugs
    A-Walrus authored and pascalkuthe committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    79a39c1 View commit details
    Browse the repository at this point in the history
  4. Update theme documentation

    A-Walrus authored and pascalkuthe committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    de72b9c View commit details
    Browse the repository at this point in the history
  5. Detect extended underline support using terminfo

    The cxterminfo crate has been used over popular alternatives
    like `term` since it supports querying for extended capabilities
    and also for it's small codebase size (which will make it easy
    to inline it into helix in the future if required).
    sudormrfbin authored and pascalkuthe committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    79d3d44 View commit details
    Browse the repository at this point in the history
  6. make underline_style a seperate option

    Underline styles are mutally exclusive and overwrite each other.
    Therefore implementing as an modifier lead to incorrect behaviour
    when the underline style is overwritten.
    
    For backwards compatability the "underline" modified is retained (but
    deprecated). Instead the "underline_style" and "underline_color"
    optios should be used to style underlines.
    pascalkuthe committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    71ee589 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. Configuration menu
    Copy the full SHA
    114610f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7bc324f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4c36c06 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2022

  1. Configuration menu
    Copy the full SHA
    ad0eb40 View commit details
    Browse the repository at this point in the history
  2. fix typo

    Co-authored-by: Omnikar <[email protected]>
    pascalkuthe and Omnikar authored Oct 8, 2022
    Configuration menu
    Copy the full SHA
    2f7088c View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. adress review comments

    pascalkuthe committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    328c4d0 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. fix terminfo detection

    pascalkuthe committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    963a0ac View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Configuration menu
    Copy the full SHA
    66a4908 View commit details
    Browse the repository at this point in the history