Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-sort diagnostics after transaction transform #3895

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Re-sort diagnostics after transaction transform #3895

merged 1 commit into from
Sep 20, 2022

Commits on Sep 18, 2022

  1. Re-sort diagnostics after transaction transform 

    Applying document-change transactions to diagnostic ranges is not stable
with respect to the ordering of diagnostics. This can cause diagnostics
to become temporarily unordered with some edits to a document, which can
eventually break some invariants/assumptions in syntax::merge.

With this change, Document::diagnostics are always sorted.
    @the-mikedavis
    the-mikedavis committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    8aae1e9 View commit details
    Browse the repository at this point in the history