feat: File Icons in File Picker #3878
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces optional file icons for the `FilePicker`. The icons are accessed through the new `FileInfo` struct, which is a valid `Item` that includes the icon in its `Span` (if configured to do so). The idea is that `FileInfo` could be used for additional file type metadata if it is needed in the future. These icons assume the use of a nerd font, which is why they are disabled by default.
jcdickinson
commented
Sep 17, 2022
|
|
||
| fn label(&self, data: &Self::Data) -> Spans { | ||
| let mut result = vec
There was a problem hiding this comment.
I believe that's a bug that should be solved by #3839
kirawi
added
A-helix-term
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces optional file icons for the
FilePicker. The icons are accessed through the newFileInfostruct, which is a validItemthat includes the icon in itsSpan(if configured to do so).The idea is that
FileInfocould be used for additional file type metadata if it is needed in the future.These icons assume the use of a nerd font, which is why they are disabled by default.