add C-y to yank picker selection to clipboard #3786
Conversation
| @@ -556,6 +556,22 @@ impl<T: Item + 'static> Component for Picker<T> { | |||
| ctrl!('t') => { | |||
| self.toggle_preview(); | |||
| } | |||
| ctrl!('y') => { | |||
| if let Some(contents) = self.selection() { | |||
| let contents = contents.sort_text(&self.editor_data).to_string(); | |||
There was a problem hiding this comment.
(Oops, I forgot to add the comment. Here it is.)
Since the sort text is not always equal to the stringified label depending on the Item, maybe we specifically want String::from(contents.label(&self.editor_data)) so that it always copies what is actually rendered in the picker minus the style?
Also when you need a String by consuming a Cow<str>, you might want to use into_owned instead in order to steal the String if it is already allocated.
kirawi
added
S-waiting-on-author
|
i was just looking for this as i usually copy error messages often and its already a pr nice! |
|
Hi @kirawi |
|
@kirawi Could this be pushed ahead again? This is a super helpful PR! Just switched over from neovim and this is definitely something I miss :) |
|
I will finish this PR tomorrow or the day after. |
There was a problem hiding this comment.
I don't think we want to add this to the picker specifically. A command to yank the diagnostic under the cursor would be fine I think, as #9527 describes, and it would be roughly equivalent to this: just use the picker (or ]d/[d etc) to jump to a diagnostic and then have a command to yank it. Alternatively we could add a special register for the diagnostic(s) under the cursor and then it would be covered by #9552.
But as we move away from the menu::Item trait in picker and towards a table layout yanking will make less sense. We could concatenate all of the columns for the selected row but that seems hacky to me.
I think this is useful for easily searching diagnostics online.