Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config option to disable log #3783

Closed

Conversation

ChemicalXandco
Copy link
Contributor

Appending to the log file can cause write amplification on SSDs causing lots of unnecessary wear so I propose adding a configuration entry to disable it. The proposed changes do not change the current behaviour by default however it might be beneficial to turn it off by default and only turn it on when trying to diagnose a problem.

@archseer
Copy link
Member

SSDs causing lots of unnecessary wear

Try looking at all the temporary files continually written by browsers :)

Users can already stop/reduce logging by raising the log level. We currently only log errors for easier debugging (otherwise we'd have to continuously teach new users how to enable logs). The LSP was a bit noisy and would log an error if no LSP was defined but that was fixed on master.

@kirawi kirawi added A-helix-term Area: Helix term improvements S-needs-discussion Status: Needs discussion or design. labels Sep 13, 2022
@the-mikedavis
Copy link
Member

Now that #3807 is merged, you can use hx --log /dev/null

@the-mikedavis
Copy link
Member

We've further reduced logging of the really noisy stuff (83f09ec, 6bfe1dd) and there are workarounds now with the --log flag as mentioned above so I will close this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements S-needs-discussion Status: Needs discussion or design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants