Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "preview" release CI runs #3757

Merged
merged 2 commits into from
Sep 10, 2022

Conversation

yvt
Copy link
Contributor

@yvt yvt commented Sep 9, 2022

Expands the trigger sources of the release CI workflow (release.yml), allowing the developers to test changes to .github/workflows/release.yml easily. The new trigger sources start the workflow in a preview mode, in which it publishes build outputs as a CI artifact (example) instead of creating a new release so that they can be manually inspected.

The following events trigger the preview mode:

  • Pushing to any branch matching the glob pattern patch/ci-release-*.
  • Opening a pull request that modifies .github/workflows/release.yml.
  • Pushing versioning tags to a forked repository (they would create a release otherwise).

@the-mikedavis
Copy link
Member

the-mikedavis commented Sep 9, 2022

This is quite cool, thanks for working on it 😀

I was a bit worried that it would publish draft releases which could be noisy for watchers but just uploading the artifacts is a good solution 👍

yvt and others added 2 commits September 10, 2022 13:14
Expands the trigger sources of the release CI workflow (`release.yml`),
allowing the developers to test changes to `.github/workflows/release.yml`
easily. The new trigger sources start the workflow in a "preview" mode, in
which it publishes build outputs as a CI artifact instead of creating a new
release so that they can be manually inspected.

The following events trigger the preview mode:

- Pushing to any branch matching the glob pattern `patch/ci-release-*`.
- Opening a pull request that modifies `.github/workflows/release.yml`.
- Pushing versioning tags to a forked repository.
@yvt yvt changed the title Support "draft" release CI runs Support "preview" release CI runs Sep 10, 2022
@the-mikedavis the-mikedavis merged commit 02d6102 into helix-editor:master Sep 10, 2022
@yvt yvt deleted the patch/ci-release-draft branch September 10, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants