Implement change_directory/show_directory commands

[simias]

These commands let the user check and change the current working directory for the running helix session.

I mostly implemented those to play with the codebase but I thought they might be useful (they would be useful to me at least, I regularly change the working directory in vim).

As an aside, I think it would be nice if TypableCommands returned a Result<()> and any error was automatically logged using editor.set_error(_), that would let one bail! out of a command implementation without having to manually call editor.set_error(format!(...)); return;. I could submit such a change if it was deemed acceptable.

[archseer]

Thanks for contributing!

As an aside, I think it would be nice if TypableCommands returned a Result<()> and any error was automatically logged using editor.set_error(_), that would let one bail! out of a command implementation without having to manually call editor.set_error(format!(...)); return;. I could submit such a change if it was deemed acceptable.

I think this would be a worthwhile change now that :commands are typed separately from regular commands. Most :commands should have some sort of output on error. You could probably define a new error type with thiserror similar to

helix/helix-lsp/src/lib.rs

Lines 43 to 44 in aca9d73

	#[error(transparent)]
	Other(#[from] anyhow::Error),

for String, that way one could ? or return Err(string.into())

[CBenoit]

Looks good to me, thank you! I suggest changing just one little detail, but I'm not blocking. You also need to fix lints (see CI, but that's basically cargo clippy + cargo fmt).
Also, what about change-working-directory and show-working-directory for names?

As an aside, I think it would be nice if TypableCommands returned a Result<()> …

Agreed! Do you plan on doing a PR for that next?

[simias]

Yeah I think I can submit a PR for the Result. At least if you're not in a hurry, I don't have a lot of time for hobby work these days...

[simias]

Oh I just your point regarding the naming, I'm absolutely fine renaming them. For the record both Vim and Rust call it the "current directory", so an alternative could be show|change-current-directory but now we're seriously nearing bikeshed territory...

[CBenoit]

Yeah I think I can submit a PR for the Result. At least if you're not in a hurry, I don't have a lot of time for hobby work these days...

No hurry 🙂

Oh I just your point regarding the naming, I'm absolutely fine renaming them. For the record both Vim and Rust call it the "current directory", so an alternative could be show|change-current-directory but now we're seriously nearing bikeshed territory...

I'm fine with either one. Just take show|change-current-directory if it's used by VIM and Rust, and let's call it a day. 👍

[simias]

Arg, I used the "working" version. Well let me amend it quickly.

[CBenoit]

Looks good! Thank you!