Make gutters padding automatic

[pickfire]

Remove padding gutter type, and automatically add 1 padding if gutters is
non-empty.

Fix #3111

cc @kchibisov hopefully this solves your issue

Sad to see a breaking change but it should be fine given that we haven't do a release yet

[archseer]

Please keep the element because it's still useful if you want to add padding between diagnostics and line number for example.

[pickfire]

If I add it back then it no longer fix the issue, I think probably a separate fix is needed, but for now I think it is fine.

[kchibisov]

cc @kchibisov hopefully this solves your issue

It doesn't solve my issue, the padding is still colored for me.

Like the problem that it's not like padding isn't there, but that it's using gutters color, but before it was using a backround color.

[pickfire]

Like the problem that it's not like padding isn't there, but that it's using gutters color, but before it was using a backround color.

Yes, for the extra "padding" now it uses gutter color which is correct (in case you pad it between line-numbers it won't look weird), but the 1-width padding we added by default does not use that gutter style, so it should be fine.

[archseer]

You forgot to remove the padding component from the default: https://github.com/helix-editor/helix/blob/dfc31e74af1b96d9097496f1faa38710ecd30580/helix-view/src/editor.rs#L476=

[archseer]

Fixed in 255c173