Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow EditorView access to config, plus add file modification indicator configuration option #2829

Closed
wants to merge 2 commits into from
Closed

Allow EditorView access to config, plus add file modification indicator configuration option #2829

wants to merge 2 commits into from

Conversation

sbromberger
Copy link
Contributor

@sbromberger
This commit makes the following changes:
d426b4f 
- provides visibility of the configuration to EditorView (closes #2828)
- adds a `file-modification-indicator` config option to change the string displayed
when file is modified.
@sbromberger sbromberger mentioned this pull request Jun 20, 2022
Closed
@sbromberger
Copy link
Contributor Author

I have tested the following:

  • no configuration option yields the standard (existing) [+] indicator.
  • configuration options work as expected.
  • updating the configuration and reloading will automatically update any indicators on open buffers (due to the Arc usage).

@sbromberger sbromberger mentioned this pull request Jun 20, 2022
Closed
@sbromberger
Copy link
Contributor Author

Closing in favor of #2831.

@sbromberger sbromberger deleted the sbromberger/editorview-config-file-modification-indicator branch June 20, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[dev] EditorView doesn't have an easy way to access Editor config elements
1 participant
@sbromberger