Add command to restart LSP server #2105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threecgreen
force-pushed
the
lsp-restart
branch
from
555c725
to
acb222b
Compare
Useful if LSP configuration changes or crashes
threecgreen
force-pushed
the
lsp-restart
branch
from
acb222b
to
46ff498
Compare
archseer
reviewed
May 2, 2022
Comment on lines
+346
to
+355
| if let Some((_, client)) = self.inner.get(&language_config.scope) { | ||
| Ok(client.clone()) | ||
| } else { | ||
| let id = self.counter.fetch_add(1, Ordering::Relaxed); | ||
| let client = self.initialize_client(language_config, config, id)?; // initialize a new client | ||
| self.inner | ||
| .insert(language_config.scope.clone(), (id, client.clone())); | ||
| Ok(client) | ||
| } | ||
| } |
There was a problem hiding this comment.
Why the change here? This was deliberate since we don't want to try reinitializing the client if we already tried starting it and failed.
There was a problem hiding this comment.
the functionality of get should be unchanged; I pulled out initialize_client into its own function so that I could also use it in restart. I switched from using self.inner.entry to self.inner.get to avoid multiple mutable borrows.
the-mikedavis
added
the
S-waiting-on-review
|
this!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #523.
Based on the discussion in #533, there's additional events I should be handling, but I wanted to make sure I was on the right track.