Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish a source tarball with version and grammars #1875

Merged
merged 3 commits into from
Mar 29, 2022

Conversation

the-mikedavis
Copy link
Member

@the-mikedavis the-mikedavis commented Mar 29, 2022

A few changes here:

  • publish the source tarball with grammars already fetched and including a VERSION file with the tag name
  • read the release VERSION file for the current version

for example:

$ cargo run -- --version
helix 22.03 (b222aba3)

Separating out the fetching and compression of grammars speeds up the workflow quite a bit. A lot of time would get wasted on upload/download-artifacts for the files from runtime/grammars/sources

@the-mikedavis
Copy link
Member Author

the-mikedavis commented Mar 29, 2022

I have this running on my fork, should finish up in the next 10min

woohoo, it works and the binary size isn't massive! https://github.com/the-mikedavis/helix/actions/runs/2055527816

helix-term/build.rs Outdated Show resolved Hide resolved
don't need this anymore since the file is checked into source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants