commands: Replace all characters in selection, make r<ENTER> work

[vv9k]

Closes: #161
Closes: #164

[vv9k]

I pushed some changes, previously r would place all the replaced characters on one line as no new line characters were added. Now it properly replaces all characters but newlines in selection. Is this behaviour correct or should I further adjust it?

[archseer]

Good question, kakoune seems to replace newlines too but maybe we can change the behavior here.

\cc @CBenoit @pickfire any thoughts on this?

[pickfire]

I never had to replace across lines so I don't have hard opinion on this.

[CBenoit]

To be honest, my main use for replace is when I want to change one specific character, so I'm not completely sure. If anything, I think ignoring newlines plays better with line-wise selections. For example in kakoune if I want to change all characters on one line, I select with x and then replace with r{char}. However, x will select the newline character that will then get replaced and gives us an additional (and probably unwanted) {char}.

Replacing a newline could be useful to change it for a space (or something else) effectively giving us a join operation, but we already have a join command better suited for that.

TL;DR: I'm rather in favor of ignoring the newlines.

By the way, (neo)vim also ignores newlines.

Worst case, we can change the behavior again later.

[vv9k]

That is also what made me add this changes, I noticed that when I select a whole line and replace it with something the newline character also gets replaced and the next line is appended to the previously selected line.