Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default language server for JavaScript #1457

Merged
merged 2 commits into from
Jan 8, 2022
Merged

Add default language server for JavaScript #1457

merged 2 commits into from
Jan 8, 2022

Conversation

hovsater
Copy link
Contributor

@hovsater hovsater commented Jan 7, 2022

The typescript-language-server supports both JavaScript and TypeScript. We can use it as the default language server for JavaScript as well.

@stuarth
Copy link
Contributor

stuarth commented Jan 7, 2022

👏 @kevinsjoberg in case you overlook it in the CI logs, you need to run cargo xtask docgen

@hovsater
Copy link
Contributor Author

hovsater commented Jan 7, 2022

@stuarth I was a step ahead of you. Addressed in ca1771d. 🙂

archseer
archseer approved these changes Jan 8, 2022
View reviewed changes
Copy link
Member

@archseer archseer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@archseer archseer merged commit 5e22694 into helix-editor:master Jan 8, 2022
@pascalkuthe pascalkuthe mentioned this pull request Oct 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hovsater @stuarth @archseer