fix: Make Table Cells set the style of their text
#13776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`helix_tui::widgets::Cell` contains styled `Text`. In the case of a styled `Cell` with styled `Text`, the styled `Text` would override the style of the `Cell`. This led to errors where it seemed `ui.text.directory` had more priority than `ui.menu.selected` and `ui.text.focus`. This change also adds some tests from doc comments of `Text` and makes them actually tested. Closes: helix-editor#13768
CalebLarsen
force-pushed
the
uitextdirectory-has-13768
branch
from
30e6697 to
26efba0
Compare
archseer
approved these changes
Sep 15, 2025
the-mikedavis
approved these changes
Sep 15, 2025
mi2ebi
pushed a commit
to mi2ebi/helix
that referenced
this pull request
Sep 15, 2025
the-mikedavis
added a commit
that referenced
this pull request
Sep 16, 2025
This is a follow-up to #13776 to patch cell contents rather than overwrite the contents. `ui.text.focus` might only set a modifier like bold or italic. This should not become the only style in the cell: it should be layered on top so that the cell has the directory and text colors from the contents.
Contributor
|
In working on #12369, this change now makes it a bit unclear how I can always style the icons color. 
Above shows the icons color getting overridden with the Not really sure how to handle this. |
mi2ebi
pushed a commit
to mi2ebi/helix
that referenced
this pull request
Sep 22, 2025
This is a follow-up to helix-editor#13776 to patch cell contents rather than overwrite the contents. `ui.text.focus` might only set a modifier like bold or italic. This should not become the only style in the cell: it should be layered on top so that the cell has the directory and text colors from the contents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helix_tui::widgets::Cellcontains styledText. In the case of a styledCellwith styledText, the styledTextwould override the style of theCell. This led to errors where it seemedui.text.directoryhad more priority thanui.menu.selectedandui.text.focus. This change also adds some tests from doc comments ofTextand makes them actually tested.Closes: #13768
Before/After
Autocomplete:
Picker: