Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor macros and mark as experimental #1253

Merged
merged 7 commits into from
Dec 27, 2021
Merged

Refactor macros and mark as experimental #1253

merged 7 commits into from
Dec 27, 2021

Commits on Dec 24, 2021

  1. Switch macro Q and q

    @pickfire
    pickfire committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    c69b669 View commit details
    Browse the repository at this point in the history

  2. Improve macro error handling

    @pickfire
    pickfire committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    d58cb52 View commit details
    Browse the repository at this point in the history

  3. Rename play macro to replay macro 

    Macro needs to be defined first before playing so replay is more accurate.
Also, replay have the same length as record which makes it looks nice.
    @pickfire
    pickfire committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    38c03c9 View commit details
    Browse the repository at this point in the history

  4. Mark macros as experimental in docs 

    Given that currently macro does not integrate well with registers and
the internal representation of macros is expected to be changed.
    @pickfire
    pickfire committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    253fd4e View commit details
    Browse the repository at this point in the history

  5. Update macro display as [q] in message

    @pickfire
    pickfire committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    aac72c7 View commit details
    Browse the repository at this point in the history

  6. Change how macros separate keypresses 

    * Keypresses are no longer separated by spaces
* Single-character keypresses are serialized as-is
* Multi-character keypresses are delimited by `<>`
    @Omnikar @pickfire
    Omnikar authored and pickfire committed Dec 24, 2021
    Configuration menu
    Copy the full SHA
    7ba9742 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2021

  1. Extract macro parsing to helix-view and add unit tests

    @Omnikar @pickfire
    Omnikar authored and pickfire committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    6bf5099 View commit details
    Browse the repository at this point in the history