Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict tagged template language injections for ecma #12217

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

uncenter
Copy link
Contributor

@uncenter uncenter commented Dec 8, 2024

Closes #11952.

@clo4
Copy link
Contributor

clo4 commented Dec 8, 2024

What problem is this solving for you? I find this feature quite useful, at least for highlighting SQL, and I've used this with graphql in the past. And, slightly cursed, but also for highlighting bash and python using JS as the glue code.

Edit: nevermind, somehow I glossed over the issue.

@uncenter
Copy link
Contributor Author

uncenter commented Dec 8, 2024

What problem is this solving for you? I find this feature quite useful, at least for highlighting SQL, and I've used this with graphql in the past. And, slightly cursed, but also for highlighting bash and python using JS as the glue code.

Edit: nevermind, somehow I glossed over the issue.

Happy to add those to the list! sql, python, and bash... any others?

@the-mikedavis the-mikedavis added the A-language-support Area: Support for programming/text languages label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent syntax highlighting for tagged templates in JavaScript
3 participants