fix: restore the cursor shape when exiting the app #11983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TornaxO7
suggested changes
Nov 1, 2024
| @@ -1202,7 +1202,11 @@ impl Application { | |||
| .backend_mut() | |||
| .show_cursor(CursorKind::Block) | |||
| .ok(); | |||
| self.terminal.restore(terminal_config) | |||
|
|
|||
| use std::io::Write; | |||
There was a problem hiding this comment.
I'd suggest to move this import to the top of the file and not inside the function.
|
We already reset the cursor, see #10769. What is likely happening for you is that terminfo is wrong for your terminal. There is only so much we can do jn that case. Unconditionally emitting this escape sequence is what e did in the past but this doesn't work in quite a few cases. What we have now is a best effort to support as many terminals as possible. The reality is simply that there is no solution that works in all edgecases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes aim to resolve #11883.
Any feedback or suggestions for improvement are welcome :)