Add per view search location and total matches to statusline. #11700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes `search_impl` to calculate the index of the current match and the total matches in the search. It also adds a new option in the status line to show this information.
useche
force-pushed
the
search_position
branch
from
2af66e5
to
6813275
Compare
|
love this, was clearly missing |
archseer
requested changes
Sep 30, 2024
Comment on lines
+2149
to
+2153
| let (idx, mat) = mat.unwrap(); | ||
| let last_idx = match all_matches.last() { | ||
| None => idx, | ||
| Some((last_idx, _)) => last_idx, | ||
| }; |
There was a problem hiding this comment.
This is inefficient and also the reason we didn't implement it in the first place: it requires scanning through the entire document just to find a total count, and this is a significant hit on very large files/lots of matches. (Because of this vim only says 99+ if there's more than 100 matches).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes
search_implto calculate the index of the current match and the total matches in the search. It also adds a new option in the status line to show this information.