fix: Lean language server consuming excessive memory #11683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Lean process, spawned by the language server, might use excessive memory in certain situation, causing the entire system to freeze. See: leanprover/lean4#5321 The language server accepts a CLI flag for limiting memory use. I set it to 1024MB, which might be a bit arbitrary, but definitly prevents the system from crashing.
the-mikedavis
approved these changes
Sep 14, 2024
the-mikedavis
added
the
A-language-support
diucicd
pushed a commit
to diucicd/helix
that referenced
this pull request
Sep 20, 2024
) The Lean process, spawned by the language server, might use excessive memory in certain situation, causing the entire system to freeze. See: leanprover/lean4#5321 The language server accepts a CLI flag for limiting memory use. I set it to 1024MB, which might be a bit arbitrary, but definitly prevents the system from crashing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, the Lean process spawned by the language server can use excessive memory in certain situations. Even on very simple code files. That caused my system to freeze. See: leanprover/lean4#5321 . The language server accepts a CLI flag for limiting memory use. I set it to 1024MB, which might be a bit arbitrary, but definitely prevents the system from freezing. The language server seems to respect this limit. So it does not just crash when the limit is reached. Instead it even provides linting, which code lines cause this excessive memory use.