Change cursor shape on mode change #1154

sudormrfbin · 2021-11-24T06:54:58Z

Fixes #323. Due to terminal limitations we can only change the shape of the primary cursor, but it's better than nothing. ~~We can keep the previous behavior of block cursors for everything by default if needed since only the primary cursor can be changed.~~ Now by default all modes have a block cursor. Configure it like so:

[editor.cursor-shape]
normal = "block"
insert = "bar"
select = "underline"

Fixes helix-editor#323. Due to terminal limitations we can only change the shape of the primary cursor.

sudormrfbin · 2021-11-24T07:01:19Z

helix-term/src/ui/editor.rs

-                spans.push((cursor_scope, cursor_start..range.head));
+                if i != primary_idx {
+                    spans.push((cursor_scope, cursor_start..range.head));
+                }


Previously the terminal cursor was hidden and we drew our own primary cursor. Now we use the terminal cursor as the primary cursor and hence ui.cursor.primary is no longer used to style it. Is there any way to use it to style the cursor ?

Can you please add a comment for these?

I was looking for a way to style the terminal cursor so that we can still use ui.cursor.primary; it's possible to do so and vim allows it: #323 (comment).

dannasessha · 2021-11-24T14:13:35Z

There was also talk (chat) about having some difference in appearance between a cursor in an active window, and a cursor in an inactive window, in addition to the connecting idea of having an active window look different from an inactive one.

sudormrfbin · 2021-11-24T15:16:58Z

A new theme scope for ui.cursor.{active,inactive} would work, and we can already change the statusline color based on active window (we can also allow changing the background maybe ?). But that's better tackled in a separate PR.

pickfire · 2021-11-25T00:50:50Z

I did the same previously and I find it quite ugly so I didn't submit this patch.

Maybe we should use a less distracting color for the other cursors or even just hide the cursor like what vim to to avoid distraction? Especially when the other cursors look like block cursor and seemed to be distracting me.

helix-view/src/graphics.rs

pickfire · 2021-11-27T14:53:24Z

I still find the default cursor ugly and should be changed, maybe like vim hidden or different theme. Not gonna approve this now due to stylistic reasons.

sudormrfbin · 2021-11-28T09:31:42Z

@pickfire Hiding the cursors will cause confusion and make it hard to see the edit position (all the cursors may not be aligned at the same column and could be at different places). We could simply have all cursors be block by default and make shape changing opt in.

archseer · 2021-11-29T01:49:50Z

We could simply have all cursors be block by default and make shape changing opt in.

Yeah, let's make this behavior opt-in. Looks good otherwise 👍🏻

sudormrfbin · 2021-11-29T05:59:28Z

All modes have a block cursor by default now, but since we're using the terminal cursor for the primary cursor, ui.cursor.primary no longer has any effect #1154 (comment).

archseer · 2021-12-05T12:12:45Z

Hmm, I liked that behavior :/ It could be replicated on some terminals where the cursor is just an invert of fg/bg, but that's not consistent across all implementations

pickfire · 2021-12-07T15:50:44Z

opt-in is a good idea, I rather it opt-in since people may not find it look good, at least for me, I think even hiding the cursor (or use a different color) might make it look nicer than reusing the original cursor.

helix-view/src/editor.rs

pickfire

Other than the comment I think it should be good since it's opt-in.

helix-term/src/ui/editor.rs

helix-view/src/editor.rs

helix-view/src/document.rs

archseer · 2021-12-19T14:55:41Z

Finally had a chance to test this, there's a problem with regex_prompt type inputs: the terminal cursor is rendered a the bottom of the screen in the input prompt, so it's missing on the selection.

Could we retain the current behavior by only doing it if the cursor is block shaped? That way it's still stylable and we avoid issues like ^. From what I can tell kakoune's behavior matches our behavior on master: the cursors are all manually drawn.

sudormrfbin · 2021-12-23T06:33:51Z

helix-term/src/ui/editor.rs

+                    // Bar and underline cursors are drawn by the terminal
+                    // BUG: If the editor area loses focus while having a bar or
+                    // underline cursor (eg. when a regex prompt has focus) then
+                    // the primary cursor will be invisible. This doesn't happen
+                    // with block cursors since we manually draw *all* cursors.


All block cursors are manually drawn now, but we have this edge case with other cursors since there's no way of knowing if the editor are has the focus currently. I think it's okay for the most part since putting a bar cursor for normal mode seems unlikely (but it's a bug nonetheless).

archseer

Forgot about this PR 😅

It looks good now 👍🏻 can you rebase to fix conflicts and undo the tree-sitter-scala submodule change? Then we should be good to merge

sudormrfbin · 2022-01-06T06:06:53Z

Done ! TBH I forgot about the PR too :) The merge commit has some additional changes of implementing Serialize for some types since #798 requires it.

dylrich · 2022-01-11T03:35:07Z

A gentle bump since this one seems ready to go! I am very much looking forward to this feature.

Omnikar · 2022-01-23T06:03:05Z

I'm also looking forward to this feature. 👍

Change cursor shape on mode change

7961355

Fixes helix-editor#323. Due to terminal limitations we can only change the shape of the primary cursor.

sudormrfbin force-pushed the cursor-shape-new branch from db238d6 to 7961355 Compare November 24, 2021 06:56

sudormrfbin commented Nov 24, 2021

View reviewed changes

sudormrfbin mentioned this pull request Nov 24, 2021

Add option to change cursor shape on mode change #323

Closed

pickfire reviewed Nov 25, 2021

View reviewed changes

helix-view/src/graphics.rs Outdated Show resolved Hide resolved

Use serde attribute to rename to lowercase

17473b5

Change default cursors to block for all modes

058796c

dannasessha mentioned this pull request Nov 29, 2021

Helix in unfocused window should appear differently than in a focused window #1187

Open

pickfire reviewed Dec 7, 2021

View reviewed changes

helix-view/src/editor.rs Outdated Show resolved Hide resolved

pickfire approved these changes Dec 7, 2021

View reviewed changes

archseer reviewed Dec 8, 2021

View reviewed changes

helix-term/src/ui/editor.rs Outdated Show resolved Hide resolved

archseer reviewed Dec 8, 2021

View reviewed changes

helix-view/src/editor.rs Outdated Show resolved Hide resolved

sudormrfbin added 2 commits December 18, 2021 08:26

Remove ui.cursor.primary and hashmap lookups

016640f

Merge branch 'master' into cursor-shape-new

d4fb1d0

pickfire reviewed Dec 18, 2021

View reviewed changes

helix-view/src/document.rs Show resolved Hide resolved

Manually draw all block cursors

c0bbadc

sudormrfbin commented Dec 23, 2021

View reviewed changes

archseer requested changes Jan 6, 2022

View reviewed changes

Merge branch 'master' into cursor-shape-new

4496249

Merge branch 'master' into cursor-shape-new

b3b4e78

archseer approved these changes Jan 23, 2022

View reviewed changes

archseer merged commit e2d2f19 into helix-editor:master Jan 23, 2022

Aloso mentioned this pull request Jan 31, 2022

Book shows features before they're released #1607

Closed

sudormrfbin deleted the cursor-shape-new branch March 9, 2022 18:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change cursor shape on mode change #1154

Change cursor shape on mode change #1154

sudormrfbin commented Nov 24, 2021 •

edited

Loading

sudormrfbin Nov 24, 2021

pickfire Nov 25, 2021

sudormrfbin Nov 25, 2021

dannasessha commented Nov 24, 2021

sudormrfbin commented Nov 24, 2021

pickfire commented Nov 25, 2021

pickfire commented Nov 27, 2021

sudormrfbin commented Nov 28, 2021

archseer commented Nov 29, 2021

sudormrfbin commented Nov 29, 2021

archseer commented Dec 5, 2021

pickfire commented Dec 7, 2021

pickfire left a comment

archseer commented Dec 19, 2021

sudormrfbin Dec 23, 2021 •

edited

Loading

archseer left a comment

sudormrfbin commented Jan 6, 2022

dylrich commented Jan 11, 2022

Omnikar commented Jan 23, 2022 •

edited

Loading

Change cursor shape on mode change #1154

Change cursor shape on mode change #1154

Conversation

sudormrfbin commented Nov 24, 2021 • edited Loading

sudormrfbin Nov 24, 2021

Choose a reason for hiding this comment

pickfire Nov 25, 2021

Choose a reason for hiding this comment

sudormrfbin Nov 25, 2021

Choose a reason for hiding this comment

dannasessha commented Nov 24, 2021

sudormrfbin commented Nov 24, 2021

pickfire commented Nov 25, 2021

pickfire commented Nov 27, 2021

sudormrfbin commented Nov 28, 2021

archseer commented Nov 29, 2021

sudormrfbin commented Nov 29, 2021

archseer commented Dec 5, 2021

pickfire commented Dec 7, 2021

pickfire left a comment

Choose a reason for hiding this comment

archseer commented Dec 19, 2021

sudormrfbin Dec 23, 2021 • edited Loading

Choose a reason for hiding this comment

archseer left a comment

Choose a reason for hiding this comment

sudormrfbin commented Jan 6, 2022

dylrich commented Jan 11, 2022

Omnikar commented Jan 23, 2022 • edited Loading

sudormrfbin commented Nov 24, 2021 •

edited

Loading

sudormrfbin Dec 23, 2021 •

edited

Loading

Omnikar commented Jan 23, 2022 •

edited

Loading