Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix hsplit and vsplit with parameter #1127

Closed
wants to merge 1 commit into from
Closed

fix hsplit and vsplit with parameter #1127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions helix-term/src/commands.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2337,10 +2337,12 @@ mod cmd {
args: &[&str],
_event: PromptEvent,
) -> anyhow::Result<()> {
use helix_core::path::expand_tilde;
let id = view!(cx.editor).doc;

if let Some(path) = args.get(0) {
cx.editor.open(path.into(), Action::VerticalSplit)?;
cx.editor
.open(expand_tilde(Path::new(path)), Action::VerticalSplit)?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong place to fix, instead we want to expand tilde at the start of canonicalize (instead of at the end when we normalize

helix/helix-core/src/path.rs

Line 43 in b99db7c

let path = expand_tilde(path);
)

I'll write a quick patch

} else {
cx.editor.switch(id, Action::VerticalSplit);
}
Expand All @@ -2353,10 +2355,12 @@ mod cmd {
args: &[&str],
_event: PromptEvent,
) -> anyhow::Result<()> {
use helix_core::path::expand_tilde;
let id = view!(cx.editor).doc;

if let Some(path) = args.get(0) {
cx.editor.open(path.into(), Action::HorizontalSplit)?;
cx.editor
.open(expand_tilde(Path::new(path)), Action::HorizontalSplit)?;
} else {
cx.editor.switch(id, Action::HorizontalSplit);
}
Expand Down